chore: Remove domains from setup wizard #30820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #30820 +/- ##
===========================================
- Coverage 63.21% 62.80% -0.42%
===========================================
Files 985 983 -2
Lines 67119 67059 -60
===========================================
- Hits 42429 42116 -313
- Misses 24690 24943 +253
|
deepeshgarg007
requested review from
nextchamp-saqib and
marination
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only visible change to the users will be the below step missing from the setup wizard. After the domain separation from ERPNext this step was obsolete and didn't do much. The domain field in company master has been made data fields so that there is no data loss for the old user migrations